✨ Store client protocol on Agent
#684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
client-protocol
branch
from
cc58b8a
to
0b44e80
Compare
alecgibson
force-pushed
the
client-protocol
branch
from
0b44e80
to
78c5f03
Compare
1 task
alecgibson
force-pushed
the
client-protocol
branch
from
78c5f03
to
a7976d4
Compare
When developing new features, it will be useful to be able to compare server and client protocol versions. For example, if a server is ahead of an old client, the server could gracefully degrade performance for clients that don't support the new functionality. This change stores the client's protocol on the `Agent` so we can perform these checks. We also add a `checkAtLeast()` protocol helper function, and store the current protocol in a constant to avoid magic numbers.
alecgibson
force-pushed
the
client-protocol
branch
from
a7976d4
to
ad9aa7e
Compare
ericyhwang
reviewed
Oct 15, 2024
lib/protocol.js
Outdated
Comment on lines
10
to
12
| return toCheck.major >= checkAgainst.major && | ||
| toCheck.minor >= checkAgainst.minor; |
There was a problem hiding this comment.
ericyhwang
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing new features, it will be useful to be able to compare server and client protocol versions.
For example, if a server is ahead of an old client, the server could gracefully degrade performance for clients that don't support the new functionality.
This change stores the client's protocol on the
Agentso we can perform these checks.We also add a
checkAtLeast()protocol helper function, and store the current protocol in a constant to avoid magic numbers.