-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dock import by command 'osdsctl dock import' #1041
base: master
Are you sure you want to change the base?
Conversation
Update the latest code
Update master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I find some way to check the format of config file's content, or users should ensure the validity of the content of these two config files?
It's always good to add the validation rather than depending upon the user. Let's add the validation when we read the config file.
What this PR does / why we need it:
Support the command "osdsctl dock import" to add backend.
Which issue this PR fixes : fixes #1004
Special notes for your reviewer:
Command:
osdsctl dock import storageType dockConfigFile [-p poolConfigFile]
Nowadays it is just adding the config text in dockConfigFile and poolConfigFile to specific config files in opensds, and the format of the text has not been verified, so if the text's format of dockConfigFile or poolConfigFile is incorrect, it may cause some unexpected error. Should I find some way to check the format of config file's content, or users should ensure the validity of the content of these two config files?
Release note: