Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the code of getting pool status #1243

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

ThisIsClark
Copy link
Contributor

What this PR does / why we need it:
Make the code of getting pool status easier to be understood.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1242

Special notes for your reviewer:

Release note:

@codecov-io
Copy link

Codecov Report

Merging #1243 into development will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@               Coverage Diff               @@
##           development    #1243      +/-   ##
===============================================
+ Coverage        34.72%   34.74%   +0.01%     
===============================================
  Files               97       97              
  Lines            17665    17662       -3     
===============================================
+ Hits              6135     6137       +2     
+ Misses           10651    10648       -3     
+ Partials           879      877       -2
Impacted Files Coverage Δ
pkg/dock/discovery/discovery.go 38.94% <85.71%> (+1.64%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants