Call the System initialize: method #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires changing `Class` to store a SOM `Array` of methods rather than a Rust `Vec`. This forces a few changes on other things (e.g. we now move to vaguely Self-like maps where you first look up a method's name and get its index into the `methods` `Array`)). Because `get_method` is so critical to performance, we jump through a few hoops to remove some pointless run-time checks.
|
There's two typos in the last commit:
|
|
Rest looks good. |
|
@ptersilie Should I force push? [If you don't tell me to, I don't know that I can!] |
SOM starts programs by calling the initialize: method in System.som -- we now do this in main.rs. This means that we now start SOM programs more-or-less in the same way as other SOMs. A few things needed tweaking to enable this, mostly making sure that we fix up class references to method and class names after bootstrapping. The other major addition is that SOM appears to treat String equality and reference equality as being the same (or Java SOM might intern strings?), so we now do the same.
|
Sorry, of course. Please do a force push. |
|
Updated and force pushed. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOM runs programs by calling the
initialize:method inSystem.somand having it load the user's class. This PR makes SOM do just this (f942f27). To get to that point, we have to do various bits of preparatory work, notably supporting themethods(c64f237) andsignature(926cd5e) primitives.Note that the
methodsprimitive exposes a mutable array and we are thus currently subject to the same flaw as Java SOM in this regard (see SOM-st/SOM#35). Fixing that is for a later PR.