Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conflicts with black and flake8/reorder-imports #260

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

spyoungtech
Copy link
Owner

@spyoungtech spyoungtech commented Feb 13, 2024

This fixes issues with incompatibilities between black due to some disappointing decisions introduced in version 24 that produces incompatibilities with flake8 and reorder-python-imports

We removed some module docstrings to fix the reorder-python-imports issue. The docstrings removed were not very useful, anyhow, but the issue will resurface if we write any new module docstrings. This is a band-aid.

See:

@coveralls
Copy link

Coverage Status

coverage: 76.256% (+0.4%) from 75.892%
when pulling c40469e on fix-pre-commit
into 746d1f7 on main.

@spyoungtech spyoungtech merged commit f2d38c9 into main Feb 13, 2024
13 checks passed
@spyoungtech spyoungtech deleted the fix-pre-commit branch April 3, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants