e2e: false failures fixes

status-im · Nov 22, 2024 · 60911a1 · 60911a1
1 parent 21c2a52
commit 60911a1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/test/appium/tests/activity_center/test_activity_center.py b/test/appium/tests/activity_center/test_activity_center.py
@@ -169,7 +169,6 @@ def _device_1_creates_user():
         def _device_2_sign_in():
             self.home_2.just_fyi("Device 2 sign in, user name is " + self.username_2)
             self.home_2.reopen_app(sign_in=False)
-            self.device_2.show_profiles_button.wait_and_click()
             self.device_2.sign_in(user_name=self.username_2)
 
         self.loop.run_until_complete(run_in_parallel(((_device_1_creates_user, {}),

diff --git a/test/appium/tests/critical/chats/test_public_chat_browsing.py b/test/appium/tests/critical/chats/test_public_chat_browsing.py
@@ -225,7 +225,7 @@ def test_restore_multiaccount_with_waku_backup_remove_profile_switch(self):
 
         self.home.just_fyi("Check that can remove user from logged out state")
         self.home.reopen_app(sign_in=False)
-        user_card = self.sign_in.get_user_profile_by_name(username=self.username)
+        user_card = self.sign_in.get_user_profile_by_name(username=recover_user_name)
         user_card.open_user_options()
         self.sign_in.remove_profile_button.click()
         if not self.sign_in.element_by_translation_id("remove-profile-confirm-message").is_element_displayed(30):
@@ -234,7 +234,7 @@ def test_restore_multiaccount_with_waku_backup_remove_profile_switch(self):
 
         self.home.just_fyi("Check that removed user is not shown in the list anymore")
         self.home.reopen_app(sign_in=False)
-        if self.sign_in.element_by_text(self.username).is_element_displayed():
+        if self.sign_in.element_by_text(recover_user_name).is_element_displayed():
             self.errors.append("Removed user is re-appeared after relogin!")
 
         self.errors.verify_no_errors()
@@ -243,6 +243,7 @@ def test_restore_multiaccount_with_waku_backup_remove_profile_switch(self):
     def test_community_discovery(self):
         try:
             # workaround for case if a user is logged out in the previous test
+            self.sign_in.explore_new_status_button.click_if_shown()
             self.sign_in.sign_in(user_name=self.username)
         except NoSuchElementException:
             pass

diff --git a/test/appium/tests/critical/test_fallback.py b/test/appium/tests/critical/test_fallback.py
@@ -164,6 +164,7 @@ def test_fallback_validate_seed_phrase(self):
         self.sign_in_2.reopen_app(sign_in=False)
 
         self.sign_in_2.just_fyi("Device 2: try syncing profile")
+        self.sign_in_2.explore_new_status_button.click_if_shown()
         self.sign_in_2.sync_profile(sync_code=self.sync_code, first_user=False)
         self.sign_in_2.progress_screen_title.wait_for_element()
         assert self.sign_in_2.progress_screen_title.text == "Oops, something’s wrong"

diff --git a/test/appium/views/sign_in_view.py b/test/appium/views/sign_in_view.py
@@ -290,7 +290,6 @@ def sync_profile(self, sync_code: str, first_user: bool = True):
             self.log_in_button.click()
             self.not_now_button.click()
         else:
-            self.show_profiles_button.wait_and_click()
             self.plus_profiles_button.click()
             self.sync_or_recover_new_profile_button.click()
         self.scan_sync_code_button.click()