Minor changes with code optimization, enhancement, and better handling. #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Made- Added logic to handle non-negative pickup values and support "faux pickups" like 1/3. Ensured notationPickup is called after setting the pickup value. Validated the pickup value before passing it to MeterActions.setPickup to prevent errors. Added input validation for pickup values in flow, ensuring only valid values are processed.
… better error handling
1. made the updatePluginObj code shorter and combined categories making it easier to maintain in the long term, also ensured that the structure exists 2. minor improvements in mixedNumber function
|
Looks good. But did you test loading a plugin after these changes? |
|
I did try doing many things with the software that it offers, but i am not sure if i tested it correctly. It does seem to work properly though as far as i have done. So i believe it works good. |
|
I have encountered a new issue that music blocks being stuck on the loading screen in my local host. Please do not merge this PR yet while i confirm wether the issue is related to my pull request or not. It doesn't seem to be the problem with this part of code but i will just confirm once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are not necessary but while working on other issues i figured that it could be good improvement.