[lldb] Prevent a bunch of potential use-after-free with SwiftASTContext #9664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeSystemSwiftTypeRef::GetSwiftASTContext() may destroy and recreate any of the SwiftASTContexts in its map of contexts, so clients need to hold on to a shared pointer to avoid another thread destroying the context while it is in use. rdar://71278998
adrian-prantl
requested review from
kastiglione,
JDevlieghere and
augusto2112
|
@swift-ci test |
JDevlieghere
approved these changes
Nov 22, 2024
| @@ -78,7 +80,7 @@ class SwiftREPL : public REPL { | |||
| CompletionRequest &request) override; | |||
|
|
|||
| private: | |||
| SwiftASTContextForExpressions *m_swift_ast = nullptr; | |||
| SwiftASTContextForExpressionsSP m_swift_ast; | |||
There was a problem hiding this comment.
If you're trying to keep churn to a minimum, feel free to ignore this, but otherwise this should be m_swift_ast_sp. Looks like you're already touching a lot of callosities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeSystemSwiftTypeRef::GetSwiftASTContext() may destroy and recreate any of the SwiftASTContexts in its map of contexts, so clients need to hold on to a shared pointer to avoid another thread destroying the context while it is in use.
rdar://71278998