forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BoundsSafety] Bring full support for -fbounds-safety #9665
Open
rapidsna
wants to merge
1
commit into
swift/release/6.1
Choose a base branch
from
dev/yeoulna/upstream-bounds-safety-swift/release/6.1
base: swift/release/6.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[BoundsSafety] Bring full support for -fbounds-safety #9665
rapidsna
wants to merge
1
commit into
swift/release/6.1
from
dev/yeoulna/upstream-bounds-safety-swift/release/6.1
+212,967
−12,730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapidsna
requested review from
adrian-prantl,
devincoughlin,
hnrklssn,
patrykstefanski,
danliew-apple,
apple-fcloutier,
DougGregor and
rjmccall
November 22, 2024 02:06
@swift-ci test |
@swift-ci test llvm |
delcypher
requested review from
delcypher
and removed request for
danliew-apple
November 22, 2024 14:59
Looks like there's some problems building with gcc.
and then a whole bunch of warnings. This are all the ones that obviously looked like they were due to
|
For the macOS job we have test failures.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fbounds-safety
is a C extension to enforce bounds safety to prevent out-of-bounds (OOB) memory accesses. The extension offers bounds annotations that programmers can use to attach bounds to pointers. Using this bounds information, the compiler inserts bounds checks on every pointer dereference, ensuring that the program does not access memory outside the specified bounds. The compiler requires programmers to provide enough bounds information so that the accesses can be checked at either run time or compile time — and it rejects code if it cannot.For more details, please refer to
The bounds annotations provided by
-fbounds-safety
could potentially be useful to implement safe interoperation between C/C++ and safe languages such as Swift. Similar to lifetime dependency annotations as pitched here.This patch contains collaborative work from @rapidsna @apple-fcloutier @patrykstefanski @delcypher @hnrklssn and from many other collaborators from the optimization and debugger side of support.