Temporal: Test rejecting ISO strings with subminute offsets #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingrant
changed the title
justingrant
force-pushed
the
iso-string-timezone-subminute
branch
3 times, most recently
from
3b3bce5
to
976c865
Compare
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jul 21, 2023
To make it easier to find actual Test262 gaps, this PR removes unreachable code in ISO parsing. It also removes offset normalization code from ParseISODateTime, to better mach the spec that only normalizes downstream from parsing. Doing this exposed a test bug that's fixed in the second commit of tc39/test262#3877. I added a TODO comment to remove offset component parsing from ParseISODateTime, because it's unused.
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Jul 21, 2023
To make it easier to find actual Test262 gaps, this PR removes unreachable and unused code in ISO parsing. It also removes offset normalization code from ParseISODateTime, to better mach the spec that only normalizes downstream from ISO string parsing. Doing this exposed a test bug that's fixed in the second commit of tc39/test262#3877.
Ms2ger
approved these changes
Jul 25, 2023
Ms2ger
force-pushed
the
iso-string-timezone-subminute
branch
from
2aa65fd
to
cc70fc0
Compare
This commit verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from tc39#3862 (the tests for that PR). I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.
There was one remaining Temporal test that was parsing an ISO string with a sub-minute offset into a Temporal.TimeZone. A polyfill bug was allowing this test case to pass, even though after tc39/proposal-temporal#2607 it should have failed. This commit removes the bad test case.
ptomato
force-pushed
the
iso-string-timezone-subminute
branch
from
cc70fc0
to
cb24feb
Compare
ptomato
pushed a commit
to justingrant/proposal-temporal
that referenced
this pull request
Aug 9, 2023
To make it easier to find actual Test262 gaps, this PR removes unreachable and unused code in ISO parsing. It also removes offset normalization code from ParseISODateTime, to better mach the spec that only normalizes downstream from ISO string parsing. Doing this exposed a test bug that's fixed in the second commit of tc39/test262#3877.
ptomato
pushed a commit
to tc39/proposal-temporal
that referenced
this pull request
Aug 9, 2023
To make it easier to find actual Test262 gaps, this PR removes unreachable and unused code in ISO parsing. It also removes offset normalization code from ParseISODateTime, to better mach the spec that only normalizes downstream from ISO string parsing. Doing this exposed a test bug that's fixed in the second commit of tc39/test262#3877.
justingrant
added a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Feb 26, 2024
To make it easier to find actual Test262 gaps, this PR removes unreachable and unused code in ISO parsing. It also removes offset normalization code from ParseISODateTime, to better mach the spec that only normalizes downstream from ISO string parsing. Doing this exposed a test bug that's fixed in the second commit of tc39/test262#3877. UPSTREAM_COMMIT=212fffcd2df3d5ac6dbcc6abfb628d696c5de146
justingrant
added a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Mar 4, 2024
To make it easier to find actual Test262 gaps, this PR removes unreachable and unused code in ISO parsing. It also removes offset normalization code from ParseISODateTime, to better mach the spec that only normalizes downstream from ISO string parsing. Doing this exposed a test bug that's fixed in the second commit of tc39/test262#3877. UPSTREAM_COMMIT=212fffcd2df3d5ac6dbcc6abfb628d696c5de146
justingrant
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Mar 5, 2024
To make it easier to find actual Test262 gaps, this PR removes unreachable and unused code in ISO parsing. It also removes offset normalization code from ParseISODateTime, to better mach the spec that only normalizes downstream from ISO string parsing. Doing this exposed a test bug that's fixed in the second commit of tc39/test262#3877. UPSTREAM_COMMIT=212fffcd2df3d5ac6dbcc6abfb628d696c5de146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR verifies that ISO strings with sub-minute offsets cannot be parsed into time zone identifiers. This was a change introduced in the recently-merged tc39/proposal-temporal#2607, but tests for this case were missing from #3862 (the tests for that PR).
I noticed in codecov results on an unrelated PR that this case wasn't being tested, so fixing that mistake now.