fixed bogus proof in setEuclid_test.tla #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated in more detail the issue with the failed regression test. The failing obligation was
Cardinality (S) = 1 => S = {CHOOSE t \in S : TRUE}
During pre-processing, the old SMT backend simplified the right-hand side of this implication to
\A x : x \in S <=> (S # {} => x \in S)
which, together with the hypothesis
S # {}
available from the context, made the proof trivial.In fact, the same step was proved even without appealing to CardThm, and without the assumption
of the left-hand side of the implication. This is clearly unsound.
This small PR contains a fixed proof of this test case.
NB: Running tlapm with the option
--debug tempfiles
still produces the input files for Isabelleand Zenon, but no longer for SMT. More precisely, the files are created but are empty. Is this a
known issue?