Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix, Upgrade and Enhancements #378

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

meabed
Copy link

@meabed meabed commented Jul 16, 2020

Thank you <3! the literary is incredible!
I have been trying to bundle the library in typescript project and its always throwing an error of implicit type any - because of publishing .ts files in the build, So i have forked it and have done various chores, please have a look if this is something you would want to be merged. Thanks!!!

  • Upgraded packages to latest versions
  • Installer and ran Prettier
  • Fix build with typescript
  • Fixed types in build and published a fork 'samilify-js'

@coveralls
Copy link

coveralls commented Jul 16, 2020

Coverage Status

Coverage increased (+0.3%) to 85.859% when pulling 6f6700c on meabed:upgrade into 469c6be on tngan:master.

@tngan
Copy link
Owner

tngan commented Jul 23, 2020

@meabed Thank you so much for the contribution. We will take this PR as a reference when we start v3 development later on. I would prefer keeping samlify-js as a forked version now, and resolve the any type in this library later on.

I will mention samlify-js in the next release note as well. ❤️

@meabed
Copy link
Author

meabed commented Jul 23, 2020

You are awesome :) make people text sense, thanks 🙏 let me know how can I help if needed.

@jimisaacs
Copy link

jimisaacs commented Mar 1, 2021

@meabed I've forked and made a lot of changes myself. Considering pulling a lot of these there #412 #411

@meabed
Copy link
Author

meabed commented Mar 1, 2021

Awesome, do I need to update my pr? Or how could I help in this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants