fix: keyboard controller should attach event on document #8801
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 51e94f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
size-limit report 📦
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| this.spaceKey$.value = false; | ||
| } | ||
| }) | ||
| ); | ||
| } | ||
|
|
||
| private _isEditableElement(evt: HTMLElement) { | ||
| return evt.closest('input, textarea, [contenteditable="true")') !== null; |
There was a problem hiding this comment.
There's a syntax error in the CSS selector - [contenteditable="true") has an unmatched parenthesis instead of a closing bracket. The correct selector should be [contenteditable="true"].
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| this.shiftKey$.value = state.raw.shiftKey && state.raw.key === 'Shift'; | ||
| this._listenKeyboard('keyup', evt => { | ||
| this.shiftKey$.value = evt.shiftKey ? true : false; |
There was a problem hiding this comment.
The shiftKey$ state handling in the keyup handler differs from the keydown logic. Currently, it will set shiftKey$ to true whenever any key is released while the shift key is held. To maintain consistency with the keydown behavior, the condition should be evt.shiftKey && evt.key === "Shift".
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
No description provided.