Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix priceLine rendering when having LastPriceAnimation indicator #1733

Conversation

signatenkov
Copy link

@signatenkov signatenkov commented Nov 18, 2024

Type of PR: bugfix

PR checklist:

Note:

  • Not adding an e2e graphics test case because it is unreliable to test the Last Price Animation during it the timing of the screenshot within the animation effect.

@signatenkov signatenkov self-assigned this Nov 18, 2024
@signatenkov signatenkov changed the title Fix priceLine rendering when haviDng LastPriceAnimation indicator Fix priceLine rendering when having LastPriceAnimation indicator Nov 18, 2024
@signatenkov signatenkov marked this pull request as ready for review November 18, 2024 16:16
@SlicedSilver
Copy link
Contributor

Could we change the merge target to v5-candidate?

I think at this stage it is easier to just work with the v5 branch because it is unlikely there will be another v4 release. If we merge this into master then we also need to cherry pick it into the v5 branch anyway. So it is easier to just put it into v5, and then we don't need to worry about maintaining two branches and ensuring we haven't forgotten to move something across.

@SlicedSilver SlicedSilver added the bug Unexpected problem or unintended behavior. label Nov 18, 2024
@signatenkov
Copy link
Author

v5: #1737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LastPriceAnimation indicator overlaps priceLine axis label
2 participants