Addresses most of Brandon's concerns #14
Conversation
There was a problem hiding this comment.
This is a great start. In addition to the comments in the files, I would suggest looking through the Error List tab for the files you've added and make sure Warnings are fixed, and Messages that are not just "style" related are fixed (for example, the unused variable messages).
There are still some things missing, compared to the old directory: phone numbers, the email host, user address, and student affiliations. Maybe the title and department columns can be combined to display this data. Also the Alt Photo link should be shown for users with SVMSecure.CATS.ServiceDesk.
How do you want to handle the "All UCD" mode of the directory, where it searches the campus LDAP first, and then adds our info?
I appreciate the work you've done on this! Once we figure out the permission issues with the IDs I can approve this as a starting point.
JasonRobertFrancis
changed the title
Thanks! I will work on a few of the remaining items (email host, address, student affiliations, alt photo). I will also need to think about the All UCD mode. I wanted to at least start a conversation about a few of my changes, so I thought it would be helpful to show you where I am now. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Updates to the layout, fixes LDAP issues, adds context-specific directory.css
Adds the info missing from directory: - Department and/or student level - VMACS mobile - MIV ID - Photo use just the mailid portion of the email Fixes EmulateUser link Adds tooltip to buttons
No description provided.