Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/bootstrap 4 update #1516

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlexNetcare
Copy link
Contributor

So I tried to remove Bootstrap 3 from the build.gradle and replace it with Bootstrap 4 as I questioned here #1511.
I replaced the .less files with the newer .scss files. And I hope I did it correctly.
I looked through some pages and fixed the layout were applicable. There are still quite the differences, like some colors or line heights. But in general it feels very similiar. Having some additional thoughts on improvements and what should be adjusted, are appreciated.

@fhoeben
Copy link
Collaborator

fhoeben commented Jul 1, 2024

@tcnh I believe you looked at the theming and bootstrap styling before. Can you take a look at these changes?

@AlexNetcare
Copy link
Contributor Author

@tcnh Is there any progress on this or did I make too many errors that it is just too much to read?

@tcnh
Copy link
Contributor

tcnh commented Sep 17, 2024

Hi @AlexNetcare, I haven't had an opportunity to look at this as I've been away for a while this summer. I will make some time next monday!

@AlexNetcare
Copy link
Contributor Author

Hi @tcnh, did you have a chance to take a look at this?

@tcnh
Copy link
Contributor

tcnh commented Nov 6, 2024

I started a while ago, but I can't find the time for a proper review. Sorry for that.
It seems everything works as expected, but I do see a quite some small misalignments caused by margins and paddings that feel a little off.
I find it hard to have an opinion on this, because I haven't seen the original fitnesse bootstrap theme in years as I've been using the bootstrap-plus theme that includes bootstrap 4 for a long time.

@AlexNetcare
Copy link
Contributor Author

Some values changed from px to .rem which led to some of the misalignments. Also some colors changed even though the used css classes didn't change. I tried to avoid using custom css where possible, so I sticked with what it is right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants