Improve Workflow for Architecture Reconstruction #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved node sticks to cursor. - Keep scale of moved node (because it conveys meaning). - Prevent placement if new parent is too small. - Prevent placement if overlap with new siblings. - Prevent placement outside of graph area (under the table). - Change outline color of grabbed object to indicate if placement is possible at the current position.
…for all windows except code window, begin with undo/redo for context menu
…in the same while the right mouse button is pressed.
…ndo and redo functionality. Edge Options will only showed if some actions for this edge are offered.
…d is only used once.
Previously, the grabbed node was moved two times: 1. to follow the cursor, and 2. to correct the position based on the new parent. The process has been optimized so that only one movement is necessary. Additionally, the new position on top of the new parent is calculated once at the client that emmits the action and the coordinates are then transmitted via a MoveNetAction instead of recalculating them individually on every client.
…nt' into reflexion-improvement
…and fix a problem that the update method returns true to early.
…on after confirm.
…use I'm not sure when this case would be triggered. Unfortunately, the documentation for this case is missing.
…tries of the open issue #668.
…rotate and scale were no longer usable.
…eted state to be mistakenly created after completing the call through the context menu. Additionally, a check was added to verify whether the coordinates have actually changed.
…should not be resized should also not be rotated or scaled, as this would hinder the comparability of the nodes.
…essfully when switching to it via context menu.
…ion for unallowed node manipulation actions
Implements an action for resizing a node in 2D.
…nt' into reflexion-improvement
Use selection events of InteractableObject instead of polling.
Change commented out log message into plain comment.
…E into reflexion-improvement
ddress suggestions by reviewer @falko17.
Use explicit numbering for a doc comment where items are referenced in the following text.
As suggested by reviewer @falko17.
Previously missed one item, sorry.
…estroyer.Destroy and fix the check to determine whether a group should be displayed.
…E into reflexion-improvement
This was
linked to
issues
Oct 1, 2024
Closed
|
We have made the changes. Once this pull request is merged, issue #529 can also be closed. Somehow, I can't link the issue. |
falko17
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Thank you for the quick implementation of the suggestions! Everything looks good to me now. I've also linked #529 in the description of the PR by using closing keywords, so it will be closed once this PR is merged.
koschke
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR wraps up the first batch of changes to improve the Reflexion City for architecture reconstructions. This also fixes #529.