Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-1264: Update Exports & Add CI Tests #79

Merged
merged 65 commits into from
Oct 3, 2024
Merged

DX-1264: Update Exports & Add CI Tests #79

merged 65 commits into from
Oct 3, 2024

Conversation

ytkimirti
Copy link
Contributor

@ytkimirti ytkimirti commented Sep 23, 2024

This PR has three main changes:

  • update eslint & exports in package.json
  • fixing small errors in examples and adding extensive CI
  • llamaindex is removed, as it was causing errors explained below

Since llamaindex is removed, we will release a major version (2.0.0)

Eslint & Exports

  • Updated tsup config
  • Updated exports field in package.json

NOTE: This should not bring any breaking changes with the old version. Here is the old and new output coming from the attw cli:

rag before rag after

CI

The examples are first tested with a local build. Then, a release is made with ci tag and it's released. It's tested by deploying to Vercel and CF workers.

Copy link

linear bot commented Sep 23, 2024

package.json Outdated Show resolved Hide resolved
src/nextjs/index.ts Outdated Show resolved Hide resolved
tsup.config.ts Show resolved Hide resolved
@CahidArda CahidArda force-pushed the DX-1264 branch 5 times, most recently from 234f03a to 5519f8b Compare October 3, 2024 06:45
@CahidArda CahidArda force-pushed the DX-1264 branch 3 times, most recently from 562e2b8 to 4ea1bd6 Compare October 3, 2024 07:29
@CahidArda
Copy link
Contributor

let's squash merge

@CahidArda CahidArda changed the title DX-1264: Unify exports DX-1264: Update Exports & Add CI Tests Oct 3, 2024
also bumped langchain/community to fix the ratelimit warning

also refreshed the bun lock file
CahidArda and others added 4 commits October 3, 2024 12:31
when used locally, the project would work because it can use 'ai' installed in parent dirs. It caused an issue when deployed though.
@CahidArda CahidArda merged commit 5b804cf into master Oct 3, 2024
10 checks passed
@CahidArda CahidArda deleted the DX-1264 branch October 3, 2024 11:25
@CahidArda CahidArda mentioned this pull request Oct 3, 2024
@mrsamirr
Copy link

mrsamirr commented Oct 3, 2024

well @CahidArda,

rag-chat version llamaindex version Vercel (npm)
1.6.4 0.5.24 missing tiktoken_bg.wasm

The issue with missing tiktoken_bg.wasm on Vercel has been resolved as mentioned in this comment. After resolving this issue, the rag-chat application now works seamlessly on Vercel.

@CahidArda
Copy link
Contributor

Hey @mrsamirr,

we can reconsider adding llama parser to rag-chat in the future, but we didn't want to make installing rag-chat require that much configuration at this time.

Thanks a lot on reporting your solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants