Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build release wheels with 'release' flags #2441

Closed
wants to merge 1 commit into from
Closed

chore: build release wheels with 'release' flags #2441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/wheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ jobs:
CIBW_TEST_COMMAND: python -c "import vaex; print(vaex.from_arrays(x=[1,2]))"
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28
CIBW_ENVIRONMENT_LINUX: 'CFLAGS="-Wl,-strip-all" CXXFLAGS="-Wl,-strip-all" PATH="$HOME/.cargo/bin:$PATH"'
CIBW_ENVIRONMENT_MACOS: 'CFLAGS="-I/usr/local/include -L/usr/local/lib" CXXFLAGS="-I/usr/local/include -L/usr/local/lib" LDFLAGS="-L/usr/local/lib"'
CIBW_ENVIRONMENT_LINUX: 'CFLAGS="-Wl,-strip-all -O3 -DNDEBUG" CXXFLAGS="-Wl,-strip-all -O3 -DNDEBUG" PATH="$HOME/.cargo/bin:$PATH"'
CIBW_ENVIRONMENT_MACOS: 'CFLAGS="-O3 -DNDEBUG -I/usr/local/include -L/usr/local/lib" CXXFLAGS="-O3 -DNDEBUG -I/usr/local/include -L/usr/local/lib" LDFLAGS="-L/usr/local/lib"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR now results in duplicate -O3 in cibuildwheel:

    creating build/temp.linux-x86_64-cpython-39/src
    g++ -pthread -Wl,-strip-all -O3 -DNDEBUG -fPIC -I/tmp/pip-build-env-9s6g1w0_/overlay/lib/python3.9/site-packages/numpy/core/include -I/opt/_internal/cpython-3.9.18/include/python3.9 -c src/vaexfast.cpp -o build/temp.linux-x86_64-cpython-39/src/vaexfast.o -std=c++11 -O3 -funroll-loops -Werror=return-type -Wno-unused-parameter -g

https://github.com/vaexio/vaex/actions/runs/11234008089/job/31228927168?pr=2441#step:7:1423

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR can be superseded as follows: #2440 (comment)


- uses: actions/upload-artifact@v4
with:
Expand Down
Loading