Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove instability notice #331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove instability notice #331

wants to merge 1 commit into from
+0 −6

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Nov 25, 2024 •
edited
Loading

What changed

  • Remove the 'instability' banner from the top of the readme

Why

Guessing we wrote this before we were doing tagged releases; now that we have version numbers, breaking changes are less destructive.

@abe-winter abe-winter requested a review from a team as a code owner November 25, 2024 22:14
@abe-winter abe-winter requested review from purplenicole730, lia-viam, acmorrow and stuqdog and removed request for a team November 25, 2024 22:14
purplenicole730
purplenicole730 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@purplenicole730 purplenicole730 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reasoning! The versions making this notice no longer effective makes sense to me, as long as the others agree.

@acmorrow
Copy link
Member

I'm going to remove myself as a reviewer here, as I think this decision should rest with others.

@acmorrow acmorrow removed their request for review November 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purplenicole730 purplenicole730 purplenicole730 approved these changes

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam is a code owner automatically assigned from viamrobotics/sdk-netcode

@stuqdog stuqdog Awaiting requested review from stuqdog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abe-winter @acmorrow @purplenicole730