Feature: implement sponsored product badge and wrapper #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcaula
requested review from
filipewl,
hellofanny and
lariciamota
and removed request for
a team
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
hcaula
changed the title
hcaula
requested review from
camilavcoutinho
and removed request for
a team
|
Closing in favor of this new app I've made: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
This PR adds the "Sponsored" badge in sponsored products, as well as adds some data-properties.
To collect sponsored product metrics, the Activity Flow script will observe for specific data-properties in the HTML.
This PR adds these data-properties in a wrapper. When a product is not sponsored, the wrapper simply returns the children.
How to test it?
TBD: we're creating a test workspace with mocked sponsored products. When it's ready, I'll add it here.
To test it, search for a term and inspect a sponsored product. The data-properties should be there.
Screenshots
The badge style can be manipulated with CSS in the classes
sponsoredBadgeContainerandsponsoredBadge.Related to / Depends on
vtex-apps/product-summary-context#24