Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variant to the products query #382

Merged
merged 2 commits into from
Sep 21, 2023
Merged

add variant to the products query #382

merged 2 commits into from
Sep 21, 2023

Conversation

hiagolcm
Copy link
Contributor

What problem is this solving?

How to test it?

[Workspace](Link goes here!)

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@hiagolcm hiagolcm requested a review from a team as a code owner September 14, 2023 16:23
@hiagolcm hiagolcm requested review from gvc, lucasfp13 and RodrigoTadeuF and removed request for a team September 14, 2023 16:23
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 14, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 14, 2023

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@gabiruuuuu
Copy link

gabiruuuuu commented Sep 21, 2023

FYI: The linter Github Action is failing but it is from an older PR that didn't take that into account, and has nothing to do with these changes. We will continue with the merge and deploy of the App.

@filipewl filipewl merged commit fa1e5c7 into master Sep 21, 2023
4 of 6 checks passed
@filipewl filipewl deleted the feature/variant branch September 21, 2023 14:36
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 21, 2023

Your PR has been merged! App is being published. 🚀
Version 2.84.0 → 2.85.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants