Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELEX-4647 more unit tests #145

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Conversation

dmnapolitano
Copy link
Contributor

@dmnapolitano dmnapolitano commented Nov 20, 2024

Description

Hi! The changes in this PR:

  • address pylint complaints, although TODO ones still remain;
  • adds a BaseDataHandler abstract class that most DataHandlers are now subclasses of;
  • adds some unit tests for VersionedDataHandler although I'm sure there's more scenarios we want to test there though I'm not exactly sure what 🤔
  • ensures that all top-level imports of external packages are dependencies in setup.py;

Thanks! 🎉

Jira Ticket

ELEX-4647

Test Steps

tox or the elexmodel command of your choice 🎉

@dmnapolitano dmnapolitano requested a review from a team as a code owner November 20, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant