-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update prettier to respect stderr and stdout concurrently #722
base: master
Are you sure you want to change the base?
Conversation
For context this is the kind of
If I were to parse this instead of output.stdout |
Unit tests presented :) |
* @param {string} str - Console output to escape | ||
* @returns {string} - Pure ansi output | ||
*/ | ||
function removeANSIColorCodes(str) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had trouble even with -no-colors
with unit tests locally. Perhaps some limitation of the command line tool?
Thank you for your contribution to this project! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
In cases where prettier fails to run (see #718)
output.stdout
can be empty. Generating an annotation with a blankpath
causes a 422 validation error pushing this check to github.I have updated the logic to check both stdout and stderr, applying appropriate checks and reporting where available.