Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix HookMap description #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix HookMap description #178

wants to merge 1 commit into from

Conversation

jaluik
Copy link

@jaluik jaluik commented Oct 29, 2022

A sync hook can only be tapped with synchronous functions. So if the HookMap want to use tapAsync or tapPromise methods, it should use async hooks, such as AsyncSeriesHook.

image

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 29, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jaluik / name: jaluik (a0dc228)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaluik @alexander-akait