Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing and generating FrameRate attribute #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cnguyenWurl
Copy link

Add support for FR attribute to both reader & writer. Added new unit tests.

@cnguyenWurl cnguyenWurl marked this pull request as ready for review September 12, 2019 20:59
Copy link

@devangvdesai devangvdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnguyenWurl - rest looks good.

reader.go Outdated Show resolved Hide resolved
reader.go Show resolved Hide resolved
Copy link

@devangvdesai devangvdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

@liorwurl liorwurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants