Filter Empty Updates from YDoc.observe_after_transaction
#104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
observe_after_transaction
callbacks should only trigger if there are contentful updates to the CRDT. There are certain operations that need aYTransaction
to complete, but don't mutate any underlying state. This caused empty updates inobserve_after_transaction
, which is a meaningless event.To avoid propagating these noops, @davidbrochart and I added this boilerplate to our callbacks:
Since we expect this behavior across the board, this PR filters out empty updates before the callback is triggered, so we will no longer have to add this check on a per-case basis.