Run tests against Ruby 2.2 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The reason why
flexmockwas failing in Ruby 2.2 is because Ruby 2.2 removedtest-unitfrom its standard library. Specifying it as an explicit dependency allows tests to run (and pass) on Ruby 2.2.On the side note: we are trying to upgrade our service discovery framework airbnb/synapse to support Ruby 2.x. We've been seeing various failures reported by the community (airbnb/synapse#94, airbnb/synapse#134, airbnb/synapse#137) related to those Ruby versions so we might be sending more pull requests to zk and zookeeper gems if we discover incompatibilities with Ruby 2.x.
Thanks a lot!