Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made List and Map items non-nullable #960

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ArpanMondalGITHUB
Copy link

@ArpanMondalGITHUB ArpanMondalGITHUB commented Sep 21, 2024

made the pigeon/notification.dart file List and Map items non-nullable #942

@ArpanMondalGITHUB ArpanMondalGITHUB changed the title make List and Map items non-nullable made List and Map items non-nullable Sep 21, 2024
@chrisbobbe
Copy link
Collaborator

Please fix the CI failure and write your commit message according to our style, before we can give this a proper review.

@ArpanMondalGITHUB
Copy link
Author

ArpanMondalGITHUB commented Nov 2, 2024

i messed up the branch and the changes that i made for this pr ... i tried to cherry pick but no use ,so i had to delete the branch . can i make a another branch and make a pr for this issue and close this issue .. sorry its my 1st time with all that git command ...from next i will read 1st the git help docs...

@gnprice
Copy link
Member

gnprice commented Nov 4, 2024

There's nothing to be accomplished by closing this PR and making a new one. Whatever commits you would want to push for the new PR, you can push as an update to this PR instead. See Zulip's Git guide here:
https://zulip.readthedocs.io/en/latest/git/using.html#force-push-changes-to-github-after-you-ve-altered-your-history

If you have questions on how to do that, the #git help channel is the best place to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants