Constants should use upper case letters

github_status_builders -> GITHUB_STATUS_BUILDERS
MariaDB · Nov 26, 2024 · 66f3826 · 66f3826
1 parent 4325ee5
commit 66f3826
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 12 deletions.
diff --git a/constants.py b/constants.py
@@ -22,7 +22,7 @@
 ]
 
 # Defines what builders report status to GitHub
-github_status_builders = [
+GITHUB_STATUS_BUILDERS = [
     "aarch64-macos-compile-only",
     "amd64-debian-12",
     "amd64-debian-12-debug-embedded",

diff --git a/locks.py b/locks.py
@@ -52,7 +52,7 @@ def getLocks(props):
     assert builder_name is not None
 
     if (
-        builder_name in github_status_builders
+        builder_name in GITHUB_STATUS_BUILDERS
         or builder_name in builders_install
         or builder_name in builders_upgrade
     ):

diff --git a/master-bintars/master.cfg b/master-bintars/master.cfg
@@ -50,7 +50,7 @@ gs = reporters.GitHubStatusPush(
     startDescription="Build started.",
     endDescription="Build done.",
     verbose=True,
-    builders=github_status_builders,
+    builders=GITHUB_STATUS_BUILDERS,
 )
 c["services"].append(gs)
 c['secretsProviders'] = [secrets.SecretInAFile(dirname=os.getenv("MASTER_CREDENTIALS_DIR", default="/srv/buildbot/master/master-credential-provider"))]

diff --git a/master-docker-nonstandard-2/master.cfg b/master-docker-nonstandard-2/master.cfg
@@ -49,7 +49,7 @@ gs = reporters.GitHubStatusPush(
     startDescription="Build started.",
     endDescription="Build done.",
     verbose=True,
-    builders=github_status_builders,
+    builders=GITHUB_STATUS_BUILDERS,
 )
 c["services"].append(gs)
 c['secretsProviders'] = [secrets.SecretInAFile(dirname=os.getenv("MASTER_CREDENTIALS_DIR", default="/srv/buildbot/master/master-credential-provider"))]

diff --git a/master-docker-nonstandard/master.cfg b/master-docker-nonstandard/master.cfg
@@ -49,7 +49,7 @@ gs = reporters.GitHubStatusPush(
     startDescription="Build started.",
     endDescription="Build done.",
     verbose=True,
-    builders=github_status_builders,
+    builders=GITHUB_STATUS_BUILDERS,
 )
 c["services"].append(gs)
 c['secretsProviders'] = [secrets.SecretInAFile(dirname=os.getenv("MASTER_CREDENTIALS_DIR", default="/srv/buildbot/master/master-credential-provider"))]

diff --git a/master-nonlatent/master.cfg b/master-nonlatent/master.cfg
@@ -82,7 +82,7 @@ gs = reporters.GitHubStatusPush(
     startDescription="Build started.",
     endDescription="Build done.",
     verbose=True,
-    builders=github_status_builders,
+    builders=GITHUB_STATUS_BUILDERS,
 )
 c["services"].append(gs)
 c['secretsProviders'] = [secrets.SecretInAFile(dirname=os.getenv("MASTER_CREDENTIALS_DIR", default="/srv/buildbot/master/master-credential-provider"))]

diff --git a/master-protected-branches/master.cfg b/master-protected-branches/master.cfg
@@ -48,7 +48,7 @@ gs = reporters.GitHubStatusPush(
     startDescription="Build started.",
     endDescription="Build done.",
     verbose=True,
-    builders=github_status_builders,
+    builders=GITHUB_STATUS_BUILDERS,
 )
 c["services"].append(gs)
 c['secretsProviders'] = [secrets.SecretInAFile(dirname=os.getenv("MASTER_CREDENTIALS_DIR", default="/srv/buildbot/master/master-credential-provider"))]

diff --git a/master.cfg b/master.cfg
@@ -51,7 +51,7 @@ gs = reporters.GitHubStatusPush(
     startDescription="Build started.",
     endDescription="Build done.",
     verbose=True,
-    builders=github_status_builders,
+    builders=GITHUB_STATUS_BUILDERS,
 )
 c["services"].append(gs)
 c['secretsProviders'] = [secrets.SecretInAFile(dirname="/srv/buildbot/master/master-credential-provider")]
@@ -298,7 +298,7 @@ for builder in master_config["builders"]:
     build_type = os_info[os_name]["type"]
 
     # Add builder only if it's not a protected branches one
-    if builder not in github_status_builders:
+    if builder not in GITHUB_STATUS_BUILDERS:
         tags = [os_name]
         if arch == "s390x" and builder in builders_galera_mtr:
             tags += ["experimental"]

diff --git a/schedulers_definition.py b/schedulers_definition.py
@@ -7,7 +7,7 @@
     builders_install,
     builders_upgrade,
     builders_wordpress,
-    github_status_builders,
+    GITHUB_STATUS_BUILDERS,
     supportedPlatforms,
 )
 
@@ -18,7 +18,7 @@ def getBranchBuilderNames(props):
     mBranch = props.getProperty("master_branch")
 
     builders = list(
-        filter(lambda x: x not in github_status_builders, supportedPlatforms[mBranch])
+        filter(lambda x: x not in GITHUB_STATUS_BUILDERS, supportedPlatforms[mBranch])
     )
 
     return builders
@@ -29,7 +29,7 @@ def getProtectedBuilderNames(props):
     mBranch = props.getProperty("master_branch")
 
     builders = list(
-        filter(lambda x: x in supportedPlatforms[mBranch], github_status_builders)
+        filter(lambda x: x in supportedPlatforms[mBranch], GITHUB_STATUS_BUILDERS)
     )
 
     return builders