C-APIのnew_with_initializeで初期化した場合、metas jsonが空になってしまうことの修正 #575
+153
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamachu
commented
Aug 10, 2023
|
|
||
| #[rstest] | ||
| #[tokio::test] | ||
| async fn new_with_initialize_must_output_metas_json() { |
There was a problem hiding this comment.
動作させるためには ./target/debug/deps/model に sample.vvm を配置しないといけないので、どう初期化するかに悩んでいます…
There was a problem hiding this comment.
以前ではVV_MODELS_ROOT_DIRみたいな環境変数でmodelディレクトリの位置を制御してた記憶があります。それを入れるとか？
qryxip
reviewed
Aug 10, 2023
crates/voicevox_core_c_api/tests/e2e/testcases/synthesizer_new_with_initialize_output_json.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
new_with_initializeをload_all_models = trueな options で Synthesizerを初期化した後に、voicevox_synthesizer_get_metas_jsonを呼び出すとmetasが空文字列で返ってきてしまう。内部でmetasは取得できているのに default で返ってきてしまうのは不適切な挙動に見える。
そのため、空文字列で
metas_cstringを初期化せずに、先にsynthesizerを初期化し、そこから取得したmetasを初期値とした。関連 Issue
その他