-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C-APIのnew_with_initializeで初期化した場合、metas jsonが空になってしまうことの修正 #575
Merged
Hiroshiba
merged 6 commits into
VOICEVOX:main
from
yamachu:new_with_initialize-initialize-metas
Aug 12, 2023
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f162688
C-APIのnew_with_initialize経由で初期化したSynthesizerもmetas jsonを出力するテストの追加
yamachu b04ac83
new_with_initialize時点でmetas_cstringにCStringを出力する
yamachu adb9368
C-APIのe2eテストを書く場所があったので、そっちにテストを移植した
yamachu a5564d5
cargo fmt
yamachu 1bcb83c
Windows環境でstderrになにか出るらしい…
yamachu 0bcb13a
_ prefix を削除し、変更対象であるように見せる
yamachu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動作させるためには
./target/debug/deps/model
にsample.vvm
を配置しないといけないので、どう初期化するかに悩んでいます…There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以前では
VV_MODELS_ROOT_DIR
みたいな環境変数でmodel
ディレクトリの位置を制御してた記憶があります。それを入れるとか?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おっ、そんなものが