Skip video partition on redump-style images #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't comment on the code style itself but I can confirm this works flawlessly on macOS (Thank you so much!) |
|
Split this into 2 PRs please. One for the offset change and the other for adding Android support (although I don't know if we should bother with that). |
GXTX
reviewed
Feb 6, 2021
| @@ -58,176 +58,6 @@ | |||
| * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF | |||
| * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
| *\ | |||
|
|
|||
There was a problem hiding this comment.
Leave this as is, we have a open PR to address this with #41
GXTX
reviewed
Feb 6, 2021
| @@ -373,7 +221,7 @@ | |||
| #endif | |||
|
|
|||
|
|
|||
| #define exiso_version "2.7.1 (01.11.14)" | |||
| #define exiso_version "2.7.2 (02.04.21)" | |||
|
Changes look good, but I'd prefer to see them split into separate pull requests as they seem to be quite different in nature. The splits I'm thinking would be reasonable; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.