Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Redump/XGD ISOs and ISOs with empty directories #47

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

rapperskull
Copy link
Contributor

@rapperskull rapperskull commented Feb 25, 2021

First commit:

Second commit:

@rapperskull rapperskull changed the title Fix for Redump/XGD ISOs Fix for Redump/XGD ISOs and ISOs with empty directories Feb 28, 2021
Use correct offset when rewriting from XDG ISO
…occupy one sector)

Don't fail on empty directories
@mnadareski
Copy link

I just want to chime in that this particular PR worked for a couple of corner-case discs that I have been having an issue with previously, including the aforementioned PGR. ❤️

@MasonT8198
Copy link
Contributor

MasonT8198 commented May 26, 2021

I have tested this PR, no issues that I can detect other than a known issue with extract-xiso where it can create bad isos as brought to my attention by Vaporeon

edit: I would’ve waited on trying to implement PR #33 in case there may have been a change needed, however I doubt there would’ve been

@MasonT8198
Copy link
Contributor

PR #44 should be a suitable fix to the bad iso issue upon further research, will have to test to confirm the fix

Copy link
Contributor

@LukeUsher LukeUsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

extract-xiso is basically on life-support at this point and in desperate need of a replacement, however, as it is one of the only open-source cross-platform solutions, this does need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants