refactor: Python binding bits and pieces #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Open
|
acts-project-service
added
the
Breaks Athena build
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
This is a collection of python bindings bits that have accumulated. Related acts-project#3502. --- This pull request includes several updates to the `Acts` geometry and Python binding code. The most important changes involve the introduction of new enums and the addition of Python bindings for new geometry classes and methods. ### Geometry and Enum Updates: * Added `Face` enum to `CylinderVolumeBounds` to describe possible faces of a cylinder volume. (`Core/include/Acts/Geometry/CylinderVolumeBounds.hpp`) * Refactored `PortalShellBase` to use the `Face` enum from `CylinderVolumeBounds` instead of defining its own. (`Core/include/Acts/Geometry/PortalShell.hpp`) ### Python Bindings Enhancements: * Added new binning values to the `addBinning` function in `Base.cpp`. (`Examples/Python/src/Base.cpp`) * Extended `addGeometry` function to include new methods and enums for `CylinderVolumeBounds` and `ExtentEnvelope`. (`Examples/Python/src/Geometry.cpp`) [[1]](diffhunk://#diff-a103b5682fb7c6e7ea58777983e4381b62783b2facd3e367e03ff0a7aa49816dL181-R213) [[2]](diffhunk://#diff-a103b5682fb7c6e7ea58777983e4381b62783b2facd3e367e03ff0a7aa49816dL212-R303) * Introduced Python bindings for `CylinderVolumeStack` and its enums `AttachmentStrategy` and `ResizeStrategy`. (`Examples/Python/src/Geometry.cpp`) ### Code Cleanup: * Removed redundant includes and updated include paths to reflect new dependencies. (`Core/include/Acts/Geometry/PortalShell.hpp`, `Examples/Python/src/Geometry.cpp`) [[1]](diffhunk://#diff-80595cf723b4c4b0a2cf3de28ac0da38793f2955a2e0ce1dc4fd87381fac79aeL11-R11) [[2]](diffhunk://#diff-a103b5682fb7c6e7ea58777983e4381b62783b2facd3e367e03ff0a7aa49816dR40) [[3]](diffhunk://#diff-a103b5682fb7c6e7ea58777983e4381b62783b2facd3e367e03ff0a7aa49816dR51) These changes improve the modularity and functionality of the geometry components and enhance the Python interface for better usability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of python bindings bits that have accumulated.
Related #3502.
This pull request includes several updates to the
Actsgeometry and Python binding code. The most important changes involve the introduction of new enums and the addition of Python bindings for new geometry classes and methods.Geometry and Enum Updates:
Faceenum toCylinderVolumeBoundsto describe possible faces of a cylinder volume. (Core/include/Acts/Geometry/CylinderVolumeBounds.hpp)PortalShellBaseto use theFaceenum fromCylinderVolumeBoundsinstead of defining its own. (Core/include/Acts/Geometry/PortalShell.hpp)Python Bindings Enhancements:
addBinningfunction inBase.cpp. (Examples/Python/src/Base.cpp)addGeometryfunction to include new methods and enums forCylinderVolumeBoundsandExtentEnvelope. (Examples/Python/src/Geometry.cpp) [1] [2]CylinderVolumeStackand its enumsAttachmentStrategyandResizeStrategy. (Examples/Python/src/Geometry.cpp)Code Cleanup:
Core/include/Acts/Geometry/PortalShell.hpp,Examples/Python/src/Geometry.cpp) [1] [2] [3]These changes improve the modularity and functionality of the geometry components and enhance the Python interface for better usability.