Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add content for module 3 #5

Closed
wants to merge 13 commits into from
Closed

Conversation

mhmohona
Copy link
Contributor

Description
Added content for module 3 -

AsyncAPI Specification (SCENE) Eve helps Chan program his spaceship, so they can stay in touch.
Deep dive into various components of AsyncAPI: info, channels, components, tags, etc.
How to define operations (like send and address), messages, and schemas.

Related issue(s)
asyncapi/website#1520

@mhmohona mhmohona marked this pull request as draft November 28, 2023 10:07
@quetzalliwrites
Copy link
Member

Hey folks, so please update your planet names to:

  • Eve's planet: Capuccinova
  • Chan's planet: Brownieterra

@mhmohona mhmohona marked this pull request as ready for review December 11, 2023 06:05
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

only remark is the host of the server: space.mosquitto.org

it is not real, and also afaik in killercoda it is not possible to go outside the killercoda network, this is why in my interactive tutorial I started MQTT broker locally in killercoda container, so I think you need to use localhost - cause you will not be able to use sample document for code generation or other things in killercode

on to you @alequetzalli

@quetzalliwrites
Copy link
Member

@mhmohona ping ping, please make sure to address the important feedback that @derberg left last week :)

Comment on lines 135 to 139

---

Certainly! Here's the updated hands-on exercise, guiding you through the entire process of creating and configuring Chan's AsyncAPI document for communication with Capuccinova and beyond.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhmohona This line shows clear plagiarism from chatgpt.

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there are 3 PR's opened pointing to the exact same file step2.md.

Please unify all of those into one single PR so we can review the file as a whole.

cc @TRohit20 @mhmohona @alequetzalli

@quetzalliwrites
Copy link
Member

I noticed there are 3 PR's opened pointing to the exact same file step2.md.

Please unify all of those into one single PR so we can review the file as a whole.

I hear you, let's follow your suggestion 😸 . @TRohit20, can you please handle this one?

@TRohit20
Copy link

@alequetzalli Sure, I'd just have to close all the PRs to begin with and then merge the content into a single document which is anyhow the final output and raise a PR reflecting it.

Would you like me to proceed with that? @alequetzalli + I'm unsure if I have the repo right to close @mhmohona's PR

@mhmohona
Copy link
Contributor Author

mhmohona commented Feb 14, 2024

I have closed my PR, does it help @TRohit20?

@mhmohona mhmohona closed this Feb 14, 2024
TRohit20 added a commit to TRohit20/learning-paths that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants