-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add content for module 3 #5
Conversation
Hey folks, so please update your planet names to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
only remark is the host of the server: space.mosquitto.org
it is not real, and also afaik in killercoda it is not possible to go outside the killercoda network, this is why in my interactive tutorial I started MQTT broker locally in killercoda container, so I think you need to use localhost - cause you will not be able to use sample document for code generation or other things in killercode
on to you @alequetzalli
100-level-AsyncAPI-Intro/step2.md
Outdated
|
||
--- | ||
|
||
Certainly! Here's the updated hands-on exercise, guiding you through the entire process of creating and configuring Chan's AsyncAPI document for communication with Capuccinova and beyond. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhmohona This line shows clear plagiarism from chatgpt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there are 3 PR's opened pointing to the exact same file step2.md
.
- docs: add content for module 3 #5
- docs: adding content for module 3 #9
- docs: adding request/reply content in module-3 #11
Please unify all of those into one single PR so we can review the file as a whole.
I hear you, let's follow your suggestion 😸 . @TRohit20, can you please handle this one? |
@alequetzalli Sure, I'd just have to close all the PRs to begin with and then merge the content into a single document which is anyhow the final output and raise a PR reflecting it. Would you like me to proceed with that? @alequetzalli + I'm unsure if I have the repo right to close @mhmohona's PR |
I have closed my PR, does it help @TRohit20? |
Description
Added content for module 3 -
Related issue(s)
asyncapi/website#1520