docs: adding content for module 3 #9
Conversation
|
Hey folks, so please update your planet names to:
|
Second round done! |
|
@TRohit20 I noticed the PR description mentions you want to let the users understand what/which are the basic? components of an AsyncAPI document, including a request/reply pattern demo. |
Co-authored-by: Sergio Moya <[email protected]>
There was a problem hiding this comment.
Looks good to me, thank you @smoya for the last feedback item. As Mahfuza noted, that information will be covered in the next module 👍🏻
Do you think it looks good to you too now? 😸
|
🚀 |
There was a problem hiding this comment.
I withdraw my approval since I noticed there are 3 PR's opened pointing to the exact same file step2.md.
- docs: add content for module 3 #5
- docs: adding content for module 3 #9
- docs: adding request/reply content in module-3 #11
Please unify all of those into one single PR so we can review the file as a whole.
|
thank you for taking care of this quickly @TRohit20! appreciate your commitment 🐻 |
| roomidchat: | ||
| address: chat/{roomId} | ||
| messages: | ||
| chatMessage: |
There was a problem hiding this comment.
You are describing the message and its payload here. However, in the rest of the examples, both are refered from components.
Maybe makes sense to unify those and use references here as well.
cc @alequetzalli
There was a problem hiding this comment.
thank you for pointing this out, @smoya!
|
1st review round done @TRohit20 @alequetzalli |
|
FYI: I removed the exercises in this module because their addition here is a mistake... and as Sergio noticed, some of the content in module 4 now looked duplicate to module 3. The original goal was always to keep the exercises in module 4, so adding exercises to this module 3 is not following our 100-level intro to AsyncAPI learning path roadmap. 
|
Co-authored-by: Sergio Moya <[email protected]>
|
@mhmohona Could you kindly look into the suggestions made by Sergio as part of the technical review and make the necessary changes through commit suggestions at the earliest? Thank you! |
Co-authored-by: Mahfuza Humayra Mohona <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description
As part of creating a 100-level interactive learning path for AsyncAPI, adding the content for module 3.
Outline for the content to be present in the module from this pull request:
Module-3: AsyncAPI Specification
Spaceship fixed, we see Chan leaving to his planet on his spaceship