-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gguf: Fix ArrayBuffer.resize not supported on Firefox #638
gguf: Fix ArrayBuffer.resize not supported on Firefox #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep i'm not opposed to doing something like this 👍
(though i wish they would support it soon? is there a tracker to follow somewhere?) |
According to caniuse page, the support is experimental on version 124 (current version) of firefox (can be enabled via a flag). So I think it's expected to be stable on 125. Unfortunate I couldn't find the issue tracker anywhere so I can't confirm that information. In any way, I feel like this API is relative new on all other browsers, so it's maybe better to keep this polyfill for a while. |
let's merge @mishig25 and set a reminder to remove (in a couple of weeks?) when Firefox support is fully out? |
Merged it. Some tests were failing citing a token issue (likely because the PR comes from a fork)
|
ArrayBuffer.resize()
is not supported on Firefox. This causes the error while visualizing gguf:This PR introduces a small patch that uses a polyfill in case
ArrayBuffer.resize()
cannot be used.Tested on Firefox and Chrome.